Default bookshelf infotext

necron099
Member
 
Posts: 58
Joined: Wed Feb 27, 2013 16:10

Default bookshelf infotext

by necron099 » Wed May 18, 2016 15:49

Sorry, but I don't know where else to post this:
I've noticed this ever since the bookshelf has had it's own formspec. When you mouse over the bookshelf it doesn't have the "Bookshelf" text displayed on the screen like "Chest" or "Furnace" when you mouse over a chest or furnace.

The code in nodes.lua line 1576:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.
Code: Select all
on_construct = function(pos)
      local meta = minetest.get_meta(pos)
      meta:set_string("formspec", bookshelf_formspec)
      local inv = meta:get_inventory()
      inv:set_size("books", 8 * 2)
   end,


When it probably should be:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.
Code: Select all
on_construct = function(pos)
      local meta = minetest.get_meta(pos)
      meta:set_string("formspec", bookshelf_formspec)
      meta:set_string("infotext", "Bookshelf")
      local inv = meta:get_inventory()
      inv:set_size("books", 8 * 2)
   end,


Maybe I'm just getting nit-picky in my old age but it's more uniform. Even bookshelves need to know what they are :)
 

User avatar
TenPlus1
Member
 
Posts: 1874
Joined: Mon Jul 29, 2013 13:38
GitHub: tenplus1

Re: Default bookshelf infotext

by TenPlus1 » Wed May 18, 2016 18:12

Personally I'd remove the mouseover infotext for things like chests, bookshelves etc. anything that doesn't show actual information.
 

User avatar
azekill_DIABLO
Member
 
Posts: 3458
Joined: Wed Oct 29, 2014 20:05
GitHub: azekillDIABLO
In-game: azekill_DIABLO

Re: Default bookshelf infotext

by azekill_DIABLO » Thu May 19, 2016 15:43

yep should be optionnal

post it in feature disscussion, it's a great idea you just had ;)
Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.
Code: Select all
Hi, my username is azekill_DIABLO and i'm an exelent bug-maker(yeah...i know...i have a bad reputation)

azekill_DIABLO said: Mineyoshi+ABJ+Baggins= TOPIC HIJACKED.
My Mods and Stuff | Voxellar | VoxBox on GITHUB | M.I.L.A Monster engine
WEIRD MODDING CONTEST !!!
 


Return to Minetest Problems

Who is online

Users browsing this forum: No registered users and 5 guests

cron