3rd person view

[Amaz]

I download it from github, extract it to my home folder, run

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

cmake . -DRUN_IN_PLACE=1

Which works fine, no errors or anything, then I run

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

make -2

And when it has built minetestserver, it gives the error that I posted above. What do you mean by debug output? Oh, and I can compile other versions of Minetest fine...

[CWz]

I think that the git is broken

[BlockMen]

https://forum.minetest.net/viewtopic.php?pid=136140#p136140
https://forum.minetest.net/viewtopic.php?pid=118680#p118680
https://forum.minetest.net/viewtopic.php?pid=118097#p118097
https://forum.minetest.net/viewtopic.php?pid=113017#p113017
https://forum.minetest.net/viewtopic.php?pid=97121#p97121

Uncalled, huh? Search for "costum". I'm sorry for doing this, but it's the only way to not allow some "costum" variables into the engine.

3rd person needs work. A lot. I don't need this feature, but it should be fixed for multiplayer.
For me it's more important to fix Pseudorandom:Next documentation which is currently lying to us.

No, you are not sorry for doing that, so dont lie. And its pitful how you get worked up over the fact i wrote a "costum" instead of "custom".

Furthermore, you dont understand even a little how the code for 3rd person works. The animations of other players is not effected and handled by server (what can cause lags). This patch only controls the animation of your own player model and only in your client. So you complain about something that is always present and is not related to this patch.

You seem having serious problems boy if you get worked up that much over it, even more by the fact you dont have any opportunity to protect the engine against "some "costum" variables "...


@Amaz, sorry, i have no idea what could cause this. for me it builds fine under win7 and MSVC, but since im not familar with ubuntu and make i cant really help you here i guess. But in general this branch is kinda outdated.

[Amaz]

Okay... Does this have anything to do with it?
[spoiler][ 37%] Building CXX object src/CMakeFiles/minetest.dir/camera.cpp.o
/home/charles/minetest/src/camera.cpp:399:29: error: ‘THIRD_FRONT’ was not declared in this scope
/home/charles/minetest/src/camera.cpp:475:42: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
make[2]: *** [src/CMakeFiles/minetest.dir/camera.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/minetest.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 38%] Building CXX object src/CMakeFiles/minetestserver.dir/content_abm.cpp.o[/spoiler]

If not, I guess I'll just have to try it on a virtual machine... Thanks for your help though... Is it possible to build minetest without building minetestserver? Because it stops working only after it has built minetestserver...

@4aiman
Does it really matter? I think that you are making much ado about nothing.
And who on earth bases their spelling of a forum?!?

[4aiman]

*I'm not a boy, I'm a real puppet!*

But enough joking. Gettin' serious.

Am I lying? Nope.
Do you believe it? I don't care.
Just fix your custom. You were asked at least 3 times and you've said you always fix misspells.
Or were you lying? But you shouldn't care what I'm telling you, probably.

On the other hand, there are other things to be fixed.
Don't tell me I don't understand something just because you want to say it.
You're only half true. Namely, my issues really have nothing to do with the patch itself.

BUT!

But if it (this patch) DOES introduce some feature then it SHOULD fix all issues that were revealed after it was applied. Even if that means rewriting descent amounts of code and fixing other coders errors/optimizing.

W/o this patch all animations work great BOTH single~ and multiplayer.
With it I had issues. Over LAN.

Otherwise this patch would remain "hacky".

And who on earth bases their spelling of a forum?!?

Believe me or not, thousands of Russian pupils do...

Also, don't make me some kind of an invalid person.
Also, should I have typoglycemia, I wouldn't be able to find this misspells as well as I wouldn't have complained about those. Have you ever read the article?..

You have "THIRD_FRONT" being not declared. That should cause problems.
I'll try to build this under ubuntu and debian and tell you the results if you want, though.
Once again, PM me the whole listing. You can use > to redirect make output to a file.

[BlockMen]

Okay... Does this have anything to do with it?
[spoiler][ 37%] Building CXX object src/CMakeFiles/minetest.dir/camera.cpp.o
/home/charles/minetest/src/camera.cpp:399:29: error: ‘THIRD_FRONT’ was not declared in this scope
/home/charles/minetest/src/camera.cpp:475:42: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
make[2]: *** [src/CMakeFiles/minetest.dir/camera.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/minetest.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 38%] Building CXX object src/CMakeFiles/minetestserver.dir/content_abm.cpp.o[/spoiler]

If not, I guess I'll just have to try it on a virtual machine... Thanks for your help though... Is it possible to build minetest without building minetestserver? Because it stops working only after it has built minetestserver...

Yes, i guess that causes the problem. Check if game.h contains https://github.com/BlockMen/minetest/blob/third_person_view/src/game.h#L127 and if camera.cpp includes game.h https://github.com/BlockMen/minetest/blob/third_person_view/src/camera.cpp#L41
And you can build just the client by specifying -DBUILD_SERVER=0



@4aiman
So, you are sorry for searching all my topics for "costum" and posting it? And im santa...
I fixed misspelling when someone told me, but since im just human i can also forget something.

And wrong, since this patch does not have any influence on the animations of other players it also has not to "fix" that. Furthermore its not easy fixable, since the lags can be caused by different problems, like slow server, slow connection, slowing down mods, etc

W/o this patch all animations work great BOTH single~ and multiplayer.
With it I had issues. Over LAN.

Ah, so the animations in singleplayer work without this patch, very interesting. And how do you see these animations, without 3rd person view? Since without this patch there isnt even a model in the world for singleplayer.

But i think its courageous of you to show everyone that you dont have any idea how things work.

[Amaz]

Okay... Does this have anything to do with it?
[spoiler][ 37%] Building CXX object src/CMakeFiles/minetest.dir/camera.cpp.o
/home/charles/minetest/src/camera.cpp:399:29: error: ‘THIRD_FRONT’ was not declared in this scope
/home/charles/minetest/src/camera.cpp:475:42: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
make[2]: *** [src/CMakeFiles/minetest.dir/camera.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/minetest.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 38%] Building CXX object src/CMakeFiles/minetestserver.dir/content_abm.cpp.o[/spoiler]

If not, I guess I'll just have to try it on a virtual machine... Thanks for your help though... Is it possible to build minetest without building minetestserver? Because it stops working only after it has built minetestserver...

Yes, i guess that causes the problem. Check if game.h contains https://github.com/BlockMen/minetest/blob/third_person_view/src/game.h#L127 and if camera.cpp includes game.h https://github.com/BlockMen/minetest/blob/third_person_view/src/camera.cpp#L41
And you can build just the client by specifying -DBUILD_SERVER=0

It contains both of those...

You have "THIRD_FRONT" being not declared. That should cause problems.
I'll try to build this under ubuntu and debian and tell you the results if you want, though.
Once again, PM me the whole listing. You can use > to redirect make output to a file.

How do I declare THIRD_FRONT?
Could you build under Ubuntu/Debian please? Thanks!
I've sent a PM.

Thanks for all your help!

[hoodedice]

@4aiman: I'll just say this:

There's a nice way of asking, and a bad way. You are certainly being overly aggressive for something that should definitely not be a problem. You are going off topic on a very serious discussion on a feature that is strongly needed for the game. You are not aiding in the development of this patch, or providing feedback, or working on anything else since you were unbanned. Moreover, you do not seemingly possess any knowledge on the topic. As such, I suggest you refrain from posting anything that is directly unrelated to this patch.

BlockMen is German. You can't get him for being wrong with his spelling as he's not a native English speaker. Moreover, he's a Core Developer, and as such, his requirement is to make good commits, not fluency in English.

The Minetest forums are related to the Minetest engine and modifications. This is not an 'English Oriented' forum. While grammatically correct English is recommended, it is not required. Why do I not see you ranting at ZachyGames, or that 170328-something guy?

*Drops the mic*



Lastly, have you been trying out this feature in FreeMiner?

[4aiman]

@ Blockmen:
How can I see animations?
Logging in with another account.
With this patch animations are broken. And in the 3rd person animations are broken too.
W/o this patch animation's "ok".

@ Hoodedice
A tripple facepalm it is:
- I failed to make Blockmen realize he should put more work onto this.
- Everyone see is just my aggression while it's 'ok' to piss off others.
- I failed to make my posts short enough to be easy to actually be read.

But to answer your question, hoodedice, yes. I've tested it in Freeminer too. And there too it works wrong.

---------------------------------------------------------------

Amaz, I'll PM you once I'm done with testing. This people are too exited about fixing anything.

Edit: Issue has been solved.
It's "CAMERA_MODE_THIRD_FRONT" not the "THIRD_FRONT".

[BlockMen]

@ Blockmen:
How can I see animations?
Logging in with another account.
With this patch animations are broken. And in the 3rd person animations are broken too.
W/o this patch animation's "ok".

ok, now you have proven that you cant differ between single- and multiplayer mode, congrats.


@Amaz, if you are still interested in this patch, its rebased and improved now, also it should compile without any problems. But keep in mind, that the animations in multiplayer dont work since no server is using this patch yet and therefore your client has not information how to animate your player.


EDIT: And a new win-build https://www.dropbox.com/s/jlpzolw5wurstze/minetest-0.4.9-tpv.zip

[stormchaser3000]

@ Blockmen:
How can I see animations?
Logging in with another account.
With this patch animations are broken. And in the 3rd person animations are broken too.
W/o this patch animation's "ok".

ok, now you have proven that you cant differ between single- and multiplayer mode, congrats.


@Amaz, if you are still interested in this patch, its rebased and improved now, also it should compile without any problems. But keep in mind, that the animations in multiplayer dont work since no server is using this patch yet and therefore your client has not information how to animate your player.


EDIT: And a new win-build https://www.dropbox.com/s/jlpzolw5wurstze/minetest-0.4.9-tpv.zip

exept my server and iluvpeeps7's server because those servers run off of a previos build of 3rd person


EDIT: nvm i tried and this did not work with the two servers i mentioned

[BlockMen]

@ Blockmen:
How can I see animations?
Logging in with another account.
With this patch animations are broken. And in the 3rd person animations are broken too.
W/o this patch animation's "ok".

ok, now you have proven that you cant differ between single- and multiplayer mode, congrats.


@Amaz, if you are still interested in this patch, its rebased and improved now, also it should compile without any problems. But keep in mind, that the animations in multiplayer dont work since no server is using this patch yet and therefore your client has not information how to animate your player.


EDIT: And a new win-build https://www.dropbox.com/s/jlpzolw5wurstze/minetest-0.4.9-tpv.zip

exept my server and iluvpeeps7's server because those servers run off of a previos build of 3rd person


EDIT: nvm i tried and this did not work with the two servers i mentioned

The way of sending the animation frames to the client has changed and is more flexible now. After updating your server make sure that this get called when player joins

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

player:set_local_animation({x=0, y=79}, {x=168, y=187}, {x=189, y=198}, {x=200, y=219}, 30)

or simply use the minetest_game in that last win build.

[Inocudom]

Could you show the link to this patch to Fess and explain to him how to compile it in his 64-bit builds?

[BlockMen]

Could you show the link to this patch to Fess and explain to him how to compile it in his 64-bit builds?

There is nothing special about the compiling. Just ask him to compile this branch: https://github.com/BlockMen/minetest/tree/third_person_view

[BrunoMine]

There is a version for linux?

[hoodedice]

There is a version for linux?

No, but I can compile it for *buntu

[BrunoMine]

There is a version for linux?

No, but I can compile it for *buntu

Please! I'll be happy

[MirceaKitsune]

Although I really hate to invalidate another developer's work, I made another patch which offers both the ability for a 3rd person view and a lot more features. I added a Lua function which can specify a position / rotation / FOV offset for the camera, making it practical for many mods. Code from here might be helpful to improve the local player model however, which is currently still networked in my patch.

For those interested, see this thread. A choice between it and this might have to be taken sadly.

[hoodedice]

There is a version for linux?

No, but I can compile it for *buntu

Please! I'll be happy

Opened up Xubuntu after a long time; Seems like it is only 5 days to 14.04, so I'll build after Trusty is out.

[gsmanners]

/me prepares to apt-get dist-upgrade

[Johnyknowhow]

Is this going to be in 4.10?

[sfan5]

Is this going to be in 4.10?

Of course, this was already added to the dev versions.

[Calinou]

Is this going to be in 4.10?

Yes!

http://dev.minetest.net/Changelog