[Mod] Compass GPS [compassgps]

[Kilarin]

<sigh> Isn't it always RIGHT AFTER you put some code out in the public that the bug shows up? My son comes up to me, not 15 minutes after I put this out and says, "Dad, It's crashing." I was very careful to convert old bookmarks. What I hadn't done was to convert old settings. If you tried to run version 1.5 of this mod with a previous settings file, it would crash. I've corrected that now. It will handle old settings files just fine now.

So, if you downloaded this and it crashed on you. Please download again, and it should run fine.

The one you mentioned in a pm, "CC BY-SA", is good.

Corrected in the readme now. thank you!

It might be handy to search by player or by bookmark name.

My son was demanding the same thing. I guess with two of you, I should see if that could be added. :)

While I'm adding things. Would people be interested in adding a text field that could be displayed for each bookmark? Essentially a journal type entry that would let you type several lines of text that would display in a text box in the gui whenever you selected that particular bookmark.

So, for example, if you created a bookmark called "big cave", you could add text that would appear (in the gui, NOT the hud) when that bookmark was selected saying: "I explored most of this, found a lot of copper near the top, but there is a large unexplored region down below that appears to be rich in mese and diamonds" Or the admin bookmark "Spawn City" might have accompanying text saying "You can get basic equipment free at the miners union, and rent an apartment at the highrise to store your stuff"

Would that be useful? Or overall, just an annoyance because you can put enough of a description into the bookmark name to tell you what you wanted to know?

I hope to see it on a server.

If you want to test it in singleplayer mode, there is a variable at the top of the ini file: show_shared_on_singleplayer=false
Change that to true and shared and admin bookmark options will appear in single player. Of course, with only one player, they aren't much use. :) A better way to test them is to open two minecraft sessions, with one as server and the other as client.

If anyone puts this on a server, please let me know. I'd love to see the shared/admin bookmarks working in a real environment.

[Kilarin]

Compass GPS is now correctly uploaded to the MineTest Mod Database https://forum.minetest.net/mmdb/mod/compassgps/

This should make it easy to install directly from MineTest. If you use it and like it (or not), please feel free to rate/review it there

[Kilarin]

Quick bug fix. The compass point_to was not saving in your settings, so you had to reselect what bookmark you wanted the compass pointing to each session.

Not very important, but patched if you want to download the new version.

[twoelk]

Compass GPS version 1.6
This mod creates a customizable compass with user settable bookmarks and shared and admin bookmarks in multiplayer.
...

reading the name of this mod I wondered if you could supply a feature like "save bookmarks as *.gpx" ;-P
not that that would be of any use in real life gadgets but some slippymaps applications, such as the googlemap api or openlayers or leaflet to name a few, can read the gpx format among others and some of these applications have been used to display minetest maps. This might be an easy way to add layers to such an application.

[Echo]

Kudos!

[TeTpaAka]

Good work!

[Kilarin]

Thank you TeTpaAka and Echo! But if its any good, its because it's built on top of your excellent code!

[lightonflux]

With the recent dev release the compass flickers if you hold it in your hand.

[Evergreen]

With the recent dev release the compass flickers if you hold it in your hand.

That's because it is replacing the item in your inventory every time it switches textures. No way to fix that (not that I know of anyway)

[lightonflux]

But it didn't happen before (at least on my end). Looks a bit like tearing.

[Kilarin]

But it didn't happen before (at least on my end). Looks a bit like tearing.

thats very interesting. they must have changed something in the engine that causes the replacement to flicker instead of happening quickly and smoothly.

That's because it is replacing the item in your inventory every time it switches textures. No way to fix that (not that I know of anyway)

There are several mods that use this strategy to change the image for a tool. Screwdriver, clock, the compasses, bridgetool, etc. It's a hack, and a clumsy one in my opinion.

What I wish the brilliant devs could figure out how to do would be to allow a mod to override the image for a particular tool without having to replace it. It would be trivial to do it for the whole class of tools, but we need a way to modify the image for the particular compassgps, clock, or screwdriver that one player is carrying and not for every compassgps, clock or screwdriver in the game. And I'm afraid that might be complicated.

[LazerRay]

I think I discovered a bug with Compass GPS, I get this error message after some time playing the game:

ERROR[ServerThread]: ERROR: An unhandled exception occurred: Couldn't save env meta
compassgps writing settings

After the message shows up in the chat console, the game basically stops working, except for player movement.

[Kilarin]

Thank you very much for the report!

Important questions:
1: Has this happened more than once?
2: What were you doing when it happened?
3: When you restarted the game, did everything work, including were your bookmarks and compassgps settings all there?

The "compassgps writing settings" message comes from the compassgps.write_settings() function (logically enough). write_settings runs every time a player leaves the game, or on shutdown:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.register_on_leaveplayer(function(player)
  compassgps.write_settings()
  end)
minetest.register_on_shutdown(compassgps.write_settings)


I'm not certain what in the compassgps code would cause a crash trying to save env meta. Since compassgps.write_settings runs every time the server shuts down, its entirely possible that you experienced a crash unrelated to compassgps which caused the server to shut down, which triggered the compassgps.write_settings function to run.

Could you send me an excerpt from your debug file for around the crash (with at least 50 lines above and below the crash itself please).

again, thank you very much for the report and I appreciate your time and effort in helping me track down the problem.

[LazerRay]

The bug seems to occur at random times, weather I'm building something, checking a crafting guide, or using an item with an inventory. I don't have the compass crafted yet, I'm just getting things set up before exploring and mining.

After restarting the game things work fine until the next crash, then nothing responds again (unable to open inventories, can't place or break blocks/nodes, interactive items stop working).

I've included the debug text from the last instance that crashed, there is nothing after the "compassgps writing settings" line since everything but player movement stopped working.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

21:11:58: ACTION[main]: [MOD]craft_guide -- loaded from C:\Users\Raymond\Documents\Game Mods\Minetest\minetest-0.4.10\bin\..\mods\craft_guide\craft_guide
[UnifiedDyes] Loaded!
[treecapitator] loaded after ca. 0.00s
compasgps reading bookmarks
compasgps reading settings
[Plantlife Library] Loaded
[Vines] Loaded!
[Moretrees] Loaded (2013-02-11)
[Poison Ivy] Loaded.
[Flowers] Loaded.
[OK] Mesecons
[buildtest] Mod loaded!
Pipeworks loaded!
Registered default:fence_wood and signs:sign_post
[Mod]Inbox Loaded!
Registered homedecor:fence_brass and homedecor:fence_brass_with_sign
Registered homedecor:fence_wrought_iron and homedecor:fence_wrought_iron_with_sign
[HomeDecor] Loaded!
[Bushes] Loaded.
21:11:59: ACTION[main]: [MOD]inventory_plus -- loaded from C:\Users\Raymond\Documents\Game Mods\Minetest\minetest-0.4.10\bin\..\mods\minetest-inventory_plus-master\inventory_plus
21:12:01: ACTION[main]:         .__               __                   __   
21:12:01: ACTION[main]:   _____ |__| ____   _____/  |_  ____   _______/  |_
21:12:01: ACTION[main]:  /     \|  |/    \_/ __ \   __\/ __ \ /  ___/\   __\
21:12:01: ACTION[main]: |  Y Y  \  |   |  \  ___/|  | \  ___/ \___ \  |  | 
21:12:01: ACTION[main]: |__|_|  /__|___|  /\___  >__|  \___  >____  > |__| 
21:12:01: ACTION[main]:       \/        \/     \/          \/     \/       
21:12:01: ACTION[main]: World at [C:\Users\Raymond\Documents\Game Mods\Minetest\minetest-0.4.10\bin\..\worlds\Peaceful Retreat]
21:12:01: ACTION[main]: Server for gameid="minetest" listening on 0.0.0.0:62669.
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Malformed iTXt chunk
Irrlicht log: PNG warning: Interlace handling should be turned on when using png_read_image
Irrlicht log: PNG warning: Malformed iTXt chunk
21:12:15: ERROR[main]: generateImage(): Could not load image "buildtest_assembly.png" while building texture
21:12:15: ERROR[main]: generateImage(): Creating a dummy image for "buildtest_assembly.png"
21:12:15: ERROR[main]: generateImage(): Could not load image "buildtest_laser_top.png" while building texture
21:12:15: ERROR[main]: generateImage(): Creating a dummy image for "buildtest_laser_top.png"
21:12:15: ERROR[main]: generateImage(): Could not load image "buildtest_laser.png" while building texture
21:12:15: ERROR[main]: generateImage(): Creating a dummy image for "buildtest_laser.png"
21:15:12: ACTION[ServerThread]: singleplayer [127.0.0.1] joins game.
Irrlicht log: Could not open file of texture: 21:15:12: ACTION[ServerThread]: singleplayer joins game. List of players: singleplayer

Irrlicht log: Could not open file of texture:
Irrlicht log: Could not open file of texture:
Irrlicht log: Could not open file of texture:
Font size: 8 17
Irrlicht log: Could not open file of texture: character.png
Irrlicht log: Could not open file of texture: sheep.png
Irrlicht log: Could not open file of texture: UV_rat.png
Irrlicht log: Could not open file of texture: sheep.png
21:15:21: ACTION[ServerThread]: singleplayer places node xpanes:pane at (-21,5,27)
21:15:22: ACTION[ServerThread]: singleplayer places node xpanes:pane at (-21,5,26)
21:15:33: ACTION[ServerThread]: singleplayer digs default:junglewood at (-29,5,32)
21:15:36: ACTION[ServerThread]: singleplayer digs default:junglewood at (-29,5,31)
21:15:39: ACTION[ServerThread]: singleplayer digs default:junglewood at (-29,5,30)
21:15:45: ACTION[ServerThread]: singleplayer places node xpanes:pane at (-29,5,32)
21:15:45: ACTION[ServerThread]: singleplayer places node xpanes:pane at (-29,5,31)
21:15:46: ACTION[ServerThread]: singleplayer places node xpanes:pane at (-29,5,30)
21:16:00: ACTION[ServerThread]: singleplayer digs default:junglewood at (-29,5,26)
21:16:00: ACTION[ServerThread]: singleplayer digs default:junglewood at (-29,5,27)
21:16:00: ACTION[ServerThread]: singleplayer digs default:junglewood at (-29,5,28)
21:16:09: ACTION[ServerThread]: singleplayer places node xpanes:pane at (-29,5,26)
21:16:10: ACTION[ServerThread]: singleplayer places node xpanes:pane at (-29,5,27)
21:16:10: ACTION[ServerThread]: singleplayer places node xpanes:pane at (-29,5,28)
21:16:30: ACTION[ServerThread]: singleplayer moves stuff to chest at (-22,3,26)
21:16:36: ACTION[ServerThread]: singleplayer moves stuff to chest at (-22,3,28)
21:17:04: ACTION[ServerThread]: singleplayer moves stuff to chest at (-22,3,28)
21:17:06: ACTION[ServerThread]: singleplayer moves stuff to chest at (-22,3,28)
21:17:58: ERROR[ServerThread]: ERROR: An unhandled exception occurred: Couldn't save env meta
compassgps writing settings


[Kilarin]

I don't have the compass crafted yet, I'm just getting things set up before exploring and mining.

Yep. I really think that what is happening is that something else is crashing.
If you don't have a compassgps crafted, then the compassgps doesn't DO anything except at load (loading settings) and shutdown (saving settings) You are crashing between those two. When you crash, the shutdown automatically triggers compassgps to try and save its settings (because of the register_on_shutdown I posted above)

Try this: Remove the compassgps mod (you aren't using it yet anyway) and see if the error still happens. I'm betting it will. And when it does, you'll get the same "Couldn't save env meta" error, but it won't be followed by a "compassgps writing settings" message anymore.

Of course, that will just prove the error is in a different mod, it won't clarify which. But it's a start.
One more thing to do, edit your minetest.conf and add debug_log_level = 4
That may give you more displays which might help clarify where the problem is.

[LazerRay]

You're right about the compass is not causing the crash, I think I found a possible cause in the debug text.

I get "INFO[ServerThread]: ServerEnvironment::saveMeta(): Failed to write C:\Users\Raymond\Documents\Game Mods\Minetest\minetest-0.4.10\bin\..\worlds\Peaceful Retreat\env_meta.txt" just before the "ERROR[ServerThread]: ERROR: An unhandled exception occurred: Couldn't save env meta" message, I'm hoping that there is a fix for this.

I'm attaching a copy of the debug text file to this post, incase there is more to the issue (the crash message is at lines 66346 and 66347 while using Notepad++)

[Kilarin]

yep, that looks like it to me. but I still don't understand what is trying to write to env_meta and crashing.
I would suggest posting this in the bugs forum.

Compassgps just writes its settings when the sever closes, so it will often be the last thing in the debug log after a crash.

Thank you for the research on this!

[LazerRay]

Looks like I'm not the only one who is getting the issue with env_meta failing to save, I found a bug report from another peson who is also getting the bug, sadly no one has posted a posible fix for it yet.

[Tril]

Hello,

Thank you for making this mod. I have a bug with multiplayer with latest Minetest.
The first time I left click while holding a compass on my server, I get the below server crash.
After the server restarts, using the compass works (to bring up the dialog box). Deleting compassgps_settings from the server's world directory causes the crash again.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

17:45:28: ACTION[ServerThread]: player Tril crafts compassgps:1
17:45:40: ACTION[ServerThread]: Tril uses compassgps:3, pointing at [nothing]
compassgps writing settings
17:45:41: ERROR[main]: ERROR: An unhandled exception occurred: /home/mine/.minetest/mods/compassgps/init.lua:1130: attempt to concatenate field '?' (a nil value)
17:45:41: ERROR[main]: stack traceback:
17:45:41: ERROR[main]:  /home/mine/.minetest/mods/compassgps/init.lua:1130: in function 'get_compassgps_formspec'
17:45:41: ERROR[main]:  /home/mine/.minetest/mods/compassgps/init.lua:1191: in function </home/mine/.minetest/mods/compassgps/init.lua:1
188>

In thread 7fc9dc9ee740:
/home/tril/src/minetest/src/main.cpp:1955: int main(int, char**): Assertion '0' failed.
Debug stacks:
DEBUG STACK FOR THREAD 7fc9dc9ee740:
#0  int main(int, char**)
(Leftover data: #1  Dedicated server branch)
(Leftover data: #2  virtual void ServerMap::save(ModifiedState))
(Leftover data: #3  void ItemStack::serialize(std::ostream&) const)
Aborted


[Kilarin]

Thanks for trying the mod, and thanks for the bug report.
Is your init.lua modified in any way from the orginal? I'm trying to make certain I'm looking at the same line numbers that are in your debug output.

[Kilarin]

I've reproduced it!
Fascinatingly strange. researching

[Kilarin]

The first time I left click while holding a compass on my server, I get the below server crash.
After the server restarts, using the compass works (to bring up the dialog box). Deleting compassgps_settings from the server's world directory causes the crash again.

Problem found and corrected. This shouldn't have been able to slip through my previous testing. Sorry about that.
Version 1.7 available on github now. I'll update the mod database as well.

Please let me know if you have any further problems. And If you get this working on a multiplayer server, I would love to know about it.

Thanks again!

[pops1345]

Hi! An other glitch.

With 4.10 and unified_inventory mod the receipe isn't shown.

I changed init.lua from

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.register_craft({
   output = 'compassgps:1',
   recipe = {
      {'', 'default:steel_ingot', ''},
      {'default:steel_ingot', 'default:mese_crystal_fragment', 'default:steel_ingot'},
      {'', 'default:steel_ingot', ''}
   }
})

to

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.register_craft({
   output = 'compassgps:0',
   recipe = {
      {'', 'default:steel_ingot', ''},
      {'default:steel_ingot', 'default:mese_crystal_fragment', 'default:steel_ingot'},
      {'', 'default:steel_ingot', ''}
   }
})

and the receipe is shown and as far as i can see everthing is working fine.

[Kilarin]

hmmm, that shouldn't work. Never tested with unified inventory. I'll download the mod and test.
but, its very late. I'll try to test with this tomorrow night. Well, actually, it's "tonight" now since it's past midnight here.

Again, thanks for the bug report!

[Kilarin]

ok, got up early so I could look at this before I went to work. your change shouldn't cause any problem at all as far as I can see. BUT, I also don't have a clue why unified inventory would care whether the compass you can craft is :1 or :0. Very strange, I'll want to do some testing with that to understand whats going on.
But it looks to me like your fix should, as you determined from your own testing, have no effect on how compassgps operates.

Thank you again, I'll look into it further.

[Kilarin]

new version 1.8 on github. I changed register_craft from compassgps:1 to compassgps:0 which makes more sense anyway and fixes compatibility with unified inventory.

Thanks!

[Fredrick01]

Kilarin, the mod is AMAZING!! Love the teleport option too! Genius thinking!

[TeTpaAka]

Hi, I get this error on load:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

14:56:05: ERROR[ServerThread]: Assignment to undeclared global "target" inside a function at /home/tetpaaka/minetest/bin/../mods/compassgps/init.lua:953.
14:56:05: ERROR[ServerThread]: Assignment to undeclared global "pos" inside a function at /home/tetpaaka/minetest/bin/../mods/compassgps/init.lua:954.
14:56:05: ERROR[ServerThread]: Assignment to undeclared global "dir" inside a function at /home/tetpaaka/minetest/bin/../mods/compassgps/init.lua:955.
14:56:05: ERROR[ServerThread]: Assignment to undeclared global "angle_dir" inside a function at /home/tetpaaka/minetest/bin/../mods/compassgps/init.lua:958.


and this when first using the compass:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

14:56:07: ERROR[ServerThread]: Assignment to undeclared global "default_bookmark" inside a function at /home/tetpaaka/minetest/bin/../mods/compassgps/init.lua:885.
14:56:07: ERROR[ServerThread]: Assignment to undeclared global "backwardscompatsave" inside a function at /home/tetpaaka/minetest/bin/../mods/compassgps/init.lua:259.
14:56:07: ERROR[ServerThread]: Assignment to undeclared global "bkmrkidx" inside a function at /home/tetpaaka/minetest/bin/../mods/compassgps/init.lua:1117.
14:56:07: ERROR[ServerThread]: Assignment to undeclared global "list" inside a function at /home/tetpaaka/minetest/bin/../mods/compassgps/init.lua:1117.


It's probably a missing local...

[Kilarin]

ugh, something new from an update pointing out something wrong I did in the original I guess. I'll get onto it as soon as I can, thank you for pointing it out.

[Kilarin]

TeTpaAka, thank you again for the bug report. I've corrected the global variables and version 1.9 is now available from git: https://github.com/Kilarin/compassgps/archive/master.zip

There is another problem I need to work on. When the original compass mod was created, you could update the compass image on the fly and it looked GOOD. When the CompassGPS fork was first released, that still worked. But in minetest 4.11 we now have a new problem. Every time the image is updated to point the compass at a new direction, the hand jogs like it was loading a new weapon. looks BAD. got to figure a way to suppress that.

Any ideas anyone?