[Mod] X-Decor [git] [xdecor]

[JingoJagget]

Well, I'm aborting the showcase idea : actually you can just drop your items and place a woodframed glass at the same position. And you get an item showcase.

Yeah, but dropped items are removed after some time.

No showcase shelf?
I was looking forward to having one in my house... Oh well.

[Fixerol]

Nice mod.
Few things I noticed:
1) if you look at trampoline from below, it will look near invisible
2) ender chest, is it ok if I put items in it and remove it totally (no items were ejected) and then place somewhere else, items will be there, so it is kind of hidden storage? you can have items in it with zero ender chests around, at any moment you can place it down and have access to them, is this correct?
3) can't saw the straw :)

[jp]

1) if you look at trampoline from below, it will look near invisible

I know, see here : https://github.com/kilbith/xdecor/issues/42

2) ender chest, is it ok if I put items in it and remove it totally (no items were ejected) and then place somewhere else, items will be there, so it is kind of hidden storage? you can have items in it with zero ender chests around, at any moment you can place it down and have access to them, is this correct?

Yes, that's a feature. It mimics Minecraft's Ender Chest.

3) can't saw the straw :)

Yes that's normal, straw is not in group "cracky" or "choppy" (i.e. not solid).

[jp]

[Update] Project moved on minetest-mods, since I don't intend to be active on Minetest anymore.

sofar accepted to take the relay for maintaining it.

[azekill_DIABLO]

i'm sad :(

[JingoJagget]

There's some nodes and stuff in the picture in the first post that I can't seem to find, like the lamp on the wall, the ceiling, and the campfire. Have those been removed?

[KCoombes]

There's some nodes and stuff in the picture in the first post that I can't seem to find, like the lamp on the wall, the ceiling, and the campfire. Have those been removed?

I believe those are the lantern placed against a wall, a candle hanging from the ceiling and the fake fire (might be wrong on that one).

[everamzah]

The first version had a metal cabinet, a skull and a brass ingot, and brass and wrought iron fences. Other versions added now gone items like a trash can, a crate, a plant potter, ... a bunch of stuff really, too much to recall.

I'm working on an xdecor_plus mod that re-adds them all (they're still present in the fork used in DCB), along with other goodies like the letterbox which only accepts written books. It's a slow going project though, and am not sure how far it'll go. I'll publish the results to online when I finish/quit.

[JingoJagget]

There's some nodes and stuff in the picture in the first post that I can't seem to find, like the lamp on the wall, the ceiling, and the campfire. Have those been removed?

I believe those are the lantern placed against a wall, a candle hanging from the ceiling and the fake fire (might be wrong on that one).

I've placed those on walls and ceilings and they don't look like that. And I don't think the version I have has fake fire. Hmmm.

[KCoombes]

There's some nodes and stuff in the picture in the first post that I can't seem to find, like the lamp on the wall, the ceiling, and the campfire. Have those been removed?

I believe those are the lantern placed against a wall, a candle hanging from the ceiling and the fake fire (might be wrong on that one).

I've placed those on walls and ceilings and they don't look like that. And I don't think the version I have has fake fire. Hmmm.

My bad - the ceiling light is the lantern (judging from the .png file in the textures). I don't see the other textures in the mod at all, so it could be the screenshot in the OP isn't current.

[bark]

When I updated xdecor, loads of my buildings broke because xdecor:cobble_wall_(variants: "ln","c1" and "c2") is missing. Does anyone know how to get them back?

[Napiophelios]

When I updated xdecor, loads of my buildings broke because xdecor:cobble_wall_(variants: "ln","c1" and "c2") is missing. Does anyone know how to get them back?

The aliases were dropped from the mod for some reason.
add this to your nodes.lua from xdecor

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

for _, n in pairs({"c0", "c1", "c2", "c3", "c4", "ln"}) do
   minetest.register_alias("xdecor:cobble_wall_"..n, "walls:cobble")
   minetest.register_alias("xdecor:mossycobble_wall_"..n, "walls:cobble")
end

However mossycobble walls will now be cobble walls.

[everamzah]

The old walls in X-Decor were from Sokomine's xconnected mod. They were dropped when NDT_CONNECTED and walls mod were added to minetest and minetest_game. I'm surprised that an alias wasn't added; perhaps a patch is in order.

[Napiophelios]

jp had aliases in the mod but removed them (and others) for some reason.
the code I posted above is his.

[bark]

Thank you! That did the trick :D

I'm having another issue: default:meselamp_microslab (i.e. meselamp that has been chopped up on workbench) doesn't exist anymore. I partly solved the issue by commenting out the bottom lines of this paragraph in workbench.lua

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- Nodes allowed to be cut.
-- Only the regular, solid blocks without metas or explosivity can be cut.
local nodes = {}
for node, def in pairs(minetest.registered_nodes) do
   if (def.drawtype == "normal" or def.drawtype:sub(1,5) == "glass") and
      (def.groups.cracky or def.groups.choppy) and
      not def.on_construct and
      not def.after_place_node and
      not def.on_rightclick and
      not def.on_blast and
      not def.allow_metadata_inventory_take and
      not (def.groups.not_in_creative_inventory == 1) and
      not def.groups.wool and
      not def.description:find("Ore") -- and
      def.description and
      def.description ~= ""
      -- def.light_source == 0
   then
      nodes[#nodes+1] = node
   end
end


Now, my meselamps are being registered, and appear in-game. But they don't emit any light. Got any suggestions?

[Napiophelios]

Haven't tested it, but open the handlers folder,
then open the registration.lua file
and add:

def.light_source = def.light_source

to the function xdecor.register(name, def) at line 45.


EDIT:

also add:

light_source = def.light_source,

to minetest.register_node at line 256
of the workbench.lua file.

seems to work for me.

[bark]

Works like a charm :)

[bark]

Warning to server admins running xdecor: https://github.com/minetest-mods/xdecor/issues/48

I temporarily solved the issue by commenting out the right-click function on node xdecor:chair in xdecor/nodes.lua.

[bark]

I'm missing yet another node. xdecor:stone_tile_stair

Got some code to get it back?

[FrancMacon]

160724072556.png (448.18 KiB) Viewed 4308 times

Via colorize

[addi]

Hi,
is there a way I can register nodes for use with the saw of Workbench?

[RHR]

Hi,
is there a way I can register nodes for use with the saw of Workbench?

Sure addi, just change the general registration of them in workbench.lua
e.g. if you want to add straw from the farming mod then add or def.name == "farming:straw" like shown in the code below

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

local nodes = {}
for node, def in pairs(minetest.registered_nodes) do
   if (def.drawtype == "normal" or def.drawtype:find("glass")) and
         (def.groups.cracky or def.groups.choppy) and not
         def.on_construct and not def.after_place_node and not
         def.after_place_node and not def.on_rightclick and not
         def.on_blast and not def.allow_metadata_inventory_take and not
         (def.groups.not_in_creative_inventory == 1) and not
         def.groups.wool and not def.description:find("Ore") and
         def.description and def.description ~= "" and def.light_source == 0
         or def.name == "farming:straw"
         then       nodes[#nodes+1] = node
   end
end

[Krock]

RHR: Be careful with these checks, for example

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

not def.description:find("Ore")

will not work when intllib is activated. It will also not work when a mod is loaded after xdecor, thus you have to put the whole thing into minetest.after or add all mods to your depends.txt.

[RHR]

RHR: Be careful with these checks, for example

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

not def.description:find("Ore")

will not work when intllib is activated. It will also not work when a mod is loaded after xdecor, thus you have to put the whole thing into minetest.after or add all mods to your depends.txt.

Krock: These checks were already part of jp's xdecor mod. I just added the one "or" line, as example to allow another node to be registered for the workbench.

[addi]

Uhm OK thanks so far. I thought something like minetest.register_stair()...
I created an issue about this: https://github.com/minetest-mods/xdecor/issues/56
I also found out, that there are hundreds of nodes registered for that saw that doesn't make logically and from looking of the textures sense.

[azekill_DIABLO]

it's even cutting spawners and mesecons :D

[KCoombes]

Any fix for this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2016-08-27 17:04:24: WARNING[Main]: Undeclared global variable "xpanes" accessed at ...sktop\minetest-0.4.14-win32\bin\..\mods\xdecor/nodes.lua:4
2016-08-27 17:04:24: ERROR[Main]: ModError: Failed to load and run script from C:\Users\User\Desktop\minetest-0.4.14-win32\bin\..\mods\xdecor\init.lua:
2016-08-27 17:04:24: ERROR[Main]: ...sktop\minetest-0.4.14-win32\bin\..\mods\xdecor/nodes.lua:4: attempt to index global 'xpanes' (a nil value)
2016-08-27 17:04:24: ERROR[Main]: stack traceback:
2016-08-27 17:04:24: ERROR[Main]:    ...sktop\minetest-0.4.14-win32\bin\..\mods\xdecor/nodes.lua:4: in function 'register_pane'
2016-08-27 17:04:24: ERROR[Main]:    ...sktop\minetest-0.4.14-win32\bin\..\mods\xdecor/nodes.lua:18: in main chunk

[Napiophelios]

I downloaded the latest Minetest game, the latest xdecor mod,
and the latest windows build by Krock; and I am not getting any errors.

[KCoombes]

I downloaded the latest Minetest game, the latest xdecor mod,
and the latest windows build by Krock; and I am not getting any errors.

I'm using sfan5's stable 04.14-win32 build with a fresh copy (yesterday) of xdecor in Minetest_game - could the build be the problem?

[Krock]

could the build be the problem?

Better sue Trump for this problem because it has absolutely nothing to do with the build.
Your error log tells me that it can't find the xpanes API function. If there is a copy of xpanes in your mods directory, remove it. Then also remove the subgame minetest_game and re-download it.