[Mod] More Trees! [git][moretrees]

[RealBadAngel]

Whenever I start up the game I get this error:



I have downloaded and installed all the latest versions of minetest, plantlife and moretrees from the first posts of your topics and from the minetest website. It still doesn't work.

You need to compile latest development version or use one of sfan5's or xyz's Minetest builds for Windows.
EDIT: It seems your 'Latest' is not latest enough :)

And where do I get xyz's build then?

http://forum.minetest.net/viewtopic.php?id=4240

[EdwardK]

Okay I read through (Forgive me if I missed anything) this post and I'm still having problems with the mod.
I have your latest plantlife-master, the latest XYZ build, and the latest version of moretrees-master.

When I attempt to enter a world I can see that plantlife-master loads, but it gets to moretrees and displays this:

ERROR[main]: ERROR FROM LUA
ERROR[main]: Failed to load and run script from
ERROR[main]: moretreesmaster\init.lua:
ERROR[main]: moretreesmaster\init.lua: 32: attempt to concatenate a nil value
ERROR[main]: stack traceable
ERROR[main]: ...0d09a8\bin\..\mods\minetest\moretreesmaster\init.lua: 32: in main chunk
ERROR[main]: END OF ERROR FROM LUA

And then it displays the typical server failed to load and run messages.

I'm completely clueless at the moment as this language is still Greek to me, any help you can offer would be great!

Thanks!
-EdwardK

[VanessaE]

Well firstly, moretrees needs to be named just "moretrees", not moretreesmaster.

Secondly, this error is not complete. Line 32 calls upon node_defs.lua but I need to know where within that file the error was (a complete past of the error will tell me).

[Topywo]

line 32: dofile(minetest.get_modpath("moretrees").."/node_defs.lua")

It should execute moretrees/node_defs.lua, but that directory doesn't exist (moretreesmaster does), resulting in a nil result trying to concatenate?

Renaming the folder to moretrees should take care of that error.

[VanessaE]

That sounds about right to me.

[EdwardK]

Yep, that's what it was.

Thank you.

[VanessaE]

2013-02-11: Added leafdecay!!

Also, made all cones + apple fall when they have nothing to hang onto. Fixed a minor bug where horizontal/sideways trunks couldn't be rotated (lacked facedir). Fixed broken birch sideways trunk recipe.

[Ragnarok]

Why jungletree leaves disappearing when I stand close to tree?

[VanessaE]

I think I know why that happens - I forgot to account for the old legacy node name for jungle tree trunks. Git updated - see if that fixes it for you.

[VanessaE]

Added the ability for this mod to perform leaf decay on default trees (defaults to false), and added the ability to redefine apples so that they fall when nearby leaves decay (defaults to true). Also moved several general config settings into moretrees/settings.lua.

[Likwid H-Craft]

Hey why not you add, Coconut tree?

[Sokomine]

Thanks for the bugfix on the vertical tree nodes! The small houses I did build for wood-traders look better now. Hopefully they can eventually be spawned and populated.

[VanessaE]

Likwid: Palm trees have coconuts.

[Inocudom]

If the jungle biome returns to Minetest, will your jungle trees appear in them and more heavily than they do normally? A jungle should be a wet place. Will the palm trees appear in them as well?

[jojoa1997]

no jungles appear in wet dirt places palm trees in beaches

[VanessaE]

I don't know what changes will take place if jungle trees are added back to the default game. That said, the ones provided by this mod aren't quite as prevalent as I wanted them to be. I'll fix this eventually.

In the meantime, new update just now:

Made leaves depend on the trunks they spawn with to avoid decaying rather than just any trunk being enough to stop just any leaves from decaying. Re-tuned the leaf decay interval/chance values accordingly. Changed a few variables to avoid possible conflicts. Added a setting to allow one to disable the new leaf decay code. Moved sapling growth code into its own file. Minor changes to comments here and there. Got rid of simple trees list (made the code do various checks in realtime instead, since it's just startup code anyway). Fixed messed-up crafting for jungle trees; condensed most of the crafting code into main craft registry loop. Mostly fixed broken aliases of default jungletrees.

[jordan4ibanez]

Nice mod, I really like it, you should have a link to plant_lib in the main post though.

[VanessaE]

It's already there, in the "Dependencies" section.

[Mito551]

i have problem with saplings spawning. both default and yours, but i disabled default. tell me what info you need in order to find the solution. thanks in advance.

[VanessaE]

First you gotta tell me what the problem IS :-)

Moretrees saplings won't spawn on anything but sand for palms and dirt with grass for everything else.

[Mito551]

First you gotta tell me what the problem IS :-)

well. as you probably fugured out (sorry for not mention the exact problem, my mind is total rubbish) saplings don't spawn.

Moretrees saplings won't spawn on anything but sand for palms and dirt with grass for everything else.

what do you mean?

[VanessaE]

I mean they won't *grow* except if planted on those surfaces, sorry. They take quite a while to grow, but this is intentional, given the average size of the trees.

Are you sure you have the very latest plants_lib and moretrees? Usually when I update one, some related update has been done to the other, so you usually have to keep them both up-to-date.

Is there anything in your install that could keep ABMs from running?

[Mito551]

Oh ok.

Pretty sure.

I was thinking something like that, but as far as I understand there shouldn't be an abm which could do this at all. If you could look through latest dwarves... Yes, I understand you may not have time, but just give a fast glance on mods which may cause the problem, I'll look into it more deeply, if I can.
Thank you

EDIT: do i have to have whole plantlife or is just the plants_lib is enough?

EDIT2:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.register_node("default:leaves", {
    description = "Leaves",
    drawtype = "allfaces_optional",
    visual_scale = 1.3,
    tiles = {"default_leaves.png"},
    paramtype = "light",
    groups = {snappy=3, leafdecay=3, flammable=2},
    drop = {
        max_items = 1,
        items = {
            {
                items = {'default:sapling'},
                rarity = 15,
            },
            {
                items = {'default:leaves'},
            }
        }
    },
    climbable = true,
    after_destruct = function(pos, node, digger)
        pos.y = pos.y + 1
        local nodename = minetest.env:get_node(pos).name
        if nodename == "snow:snow" then
            minetest.env:remove_node(pos)
        end
    end,
    sounds = default.node_sound_leaves_defaults(),
    walkable = false,
})

code for my leaves.

[VanessaE]

Only plants_lib is required to run moretrees. An ABM is really the only way to handle saplings, since after a sapling grows, there's nothing to trigger on anymore in that spot. Regarding leaves, I might consider this code in future, as I do want to make sure moretrees plays nicely with the snow mod. I just haven't had much time lately.

[Mito551]

Only plants_lib is required to run moretrees. An ABM is really the only way to handle saplings, since after a sapling grows, there's nothing to trigger on anymore in that spot. Regarding leaves, I might consider this code in future, as I do want to make sure moretrees plays nicely with the snow mod. I just haven't had much time lately.

Yeah, well. Since I'm keeping a game which is a whole, there is just no need to redefine all the stuff hundreds of times. OK, I'll try to look into the problem myself then. Thank you anyways.

[Mito551]

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

    minetest.register_abm({
        nodenames = {"moretrees:jungletree_leaves_red","moretrees:jungletree_leaves_green","moretrees:jungletree_leaves_yellow"},
        interval = moretrees.leafdecay_delay,
        chance = moretrees.leafdecay_chance,
        action = function(pos, node, active_object_count, active_object_count_wider)
            if not minetest.env:find_node_near(pos, moretrees.leafdecay_radius, {"default:jungletree", "moretrees:jungletree_trunk"}) then
                minetest.env:remove_node(pos)
                                minetest.env:dig_node(pos)
            end
        end
    })

why do you have this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.env:remove_node(pos)

having both

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.env:dig_node(pos)

and

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.env:remove_node(pos)

makes game dig only air, empty space, judging by debug.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

ACTION[ServerThread]:  digs air at (446,34,-457)

maybe that is the problem?

[VanessaE]

The purpose of that code is to force a node update, which causes "attached" items such as pine cones to fall in the case of a pine tree. If you just dig_node() first, you end up digging a leaves node, which takes a tiny bit longer than doing a remove_node() followed by digging the resultant air. This just seemed like the easiest way to do it without any side effects.

[Mito551]

The purpose of that code is to force a node update, which causes "attached" items such as pine cones to fall in the case of a pine tree. If you just dig_node() first, you end up digging a leaves node, which takes a tiny bit longer than doing a remove_node() followed by digging the resultant air. This just seemed like the easiest way to do it without any side effects.

I don't understand how that helps cones fall. Could you expand on it a bit?

[VanessaE]

Just executing remove_node() by itself doesn't cause them to fall. Adding the dig_node() call right after is what does it, probably because that call is intended to simulate a player actually digging the node (even if it's air), which triggers the engine's attached-item-falling code and also forces the engine to update the lighting in the immediate area, which tends to be a necessity with these huge trees.

[VanessaE]

2013-02-20: Made jungle trees more numerous and able to spread further from water, took leaves out of the avoidnodes table, there's really no reason to have them there and having them causes too much spacing between trees. Reduced the prevalence of sequoias.