Page 19 of 20

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Mon Aug 29, 2016 16:04
by KCoombes
I d/l'd the zip file. I will post over there too.

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Mon Aug 29, 2016 16:15
by stu
KCoombes wrote:I d/l'd the zip file. I will post over there too.

If you are able to use git then you could check the history with git log. The last commit should have been on Aug 15, 2016 - Merge pull request #63 from Wuzzy2/search by VanessaE

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Mon Aug 29, 2016 18:11
by Napiophelios
The only way I have been able to replicate anything similar is by using an old version of unified inventory.
When I press on the shield my whole screen goes grey.

The error messages are similar but not the exact same,
probably because I am testing with a Unified_Inventory from 2015
Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.
Code: Select all
2016-08-29 14:04:50: ERROR[Main]: ServerError: Lua: Runtime error from mod 'unified_inventory' in callback ScriptApiPlayer::on_playerReceiveFields(): D:\Games\MineTest\bin\..\mods\3d_armor\3d_armor/armor.lua:91: attempt to index local 'perplayer_formspec' (a nil value)
2016-08-29 14:04:50: ERROR[Main]: stack traceback:
2016-08-29 14:04:50: ERROR[Main]:    D:\Games\MineTest\bin\..\mods\3d_armor\3d_armor/armor.lua:91: in function 'get_formspec'
2016-08-29 14:04:50: ERROR[Main]:    ...ames\MineTest\bin\..\mods\unified_inventory/internal.lua:33: in function 'get_formspec'
2016-08-29 14:04:50: ERROR[Main]:    ...ames\MineTest\bin\..\mods\unified_inventory/internal.lua:131: in function 'set_inventory_formspec'
2016-08-29 14:04:50: ERROR[Main]:    D:\Games\MineTest\bin\..\mods\unified_inventory/api.lua:208: in function 'action'
2016-08-29 14:04:50: ERROR[Main]:    ...mes\MineTest\bin\..\mods\unified_inventory/callbacks.lua:62: in function <...mes\MineTest\bin\..\mods\unified_inventory/callbacks.lua:48>


When I use newly downloaded versions of Unified inventory and 3D Armor
I get no errors at all.

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Mon Aug 29, 2016 18:22
by stu
Napiophelios wrote:When I use newly downloaded versions of Unified inventory and 3D Armor
I get no errors at all.


Thanks, the error is certainly consistent with the use of an out-dated UI, however, the line number mismatch between those back-traces suggests that the poster may also need to update their 3d_armor modpack.

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Mon Aug 29, 2016 20:07
by KCoombes
stu wrote:
Napiophelios wrote:When I use newly downloaded versions of Unified inventory and 3D Armor
I get no errors at all.


Thanks, the error is certainly consistent with the use of an out-dated UI, however, the line number mismatch between those back-traces suggests that the poster may also need to update their 3d_armor modpack.


Ok, installed new copy of 3d_armor, started new world with only 3d_armor and UI, world loads fine. Then went through my list of mods and added them back, one by one, loading the world and testing the UI buttons after each one. Finally got the 'length of field 'items' ' error again, after adding my own mod; I must conclude there is an error-generating bit of code in my mod somewhere that is causing this.

Thanks for the help!

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Mon Aug 29, 2016 20:14
by stu
No problem, if you get stuck then show us your code, someone else might be able to spot the error.

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Mon Oct 24, 2016 15:39
by Andrey01
stu, will be add more armors

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Thu Oct 27, 2016 14:09
by stu
Andrey01 wrote:stu, will be add more armors

Sorry, I do not plan to add more armors, I think there are already way too many. Was there something specific you had in mind?

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Sat Oct 29, 2016 11:56
by snoopy
This is an excellent mod, thanks a lot. My kids and me use this mod since Minetest 0.4.13 as a natural addon.

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Sat Oct 29, 2016 14:21
by BrunoMine
Yes, this is one of the top 3 best mods minetest today.

Re: [Modpack] 3D Armor [0.4.5] [minetest-3d_armor]

PostPosted: Sat Oct 29, 2016 14:39
by Andrey01
BrunoMine wrote:Yes, this is one of the top 3 best mods minetest today.

And still one of the best mods that Not So Simple Mobs, i think

Re: [Modpack] 3D Armor [0.4.6] [minetest-3d_armor]

PostPosted: Sun Nov 27, 2016 17:24
by stu
Version Update 0.4.6

The armor model has been updated to include recent fixes and improvements from the minetest_game player model. I have also somewhat pre-emptively added support for named detached inventories.

https://github.com/minetest/minetest/pull/4812

Server admins note that the /kill <name> command now requires ban privileges and kills only the named player, the old /kill command functionality has been replaced with /killme which does not require any privileges or parameters.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Tue Feb 14, 2017 00:36
by JingoJagget
I downloaded the most recent version of this mod, but the armor and player preview ui's don't show up for me. :(

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Tue Feb 14, 2017 04:59
by Diamond knight
Try using inventory plus or unified inventory

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Tue Feb 14, 2017 18:37
by stu
JingoJagget wrote:I downloaded the most recent version of this mod, but the armor and player preview ui's don't show up for me. :(

It sounds like use are using creative mode. Either turn off creative or install one of the supported inventory mods, as suggested.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Tue Feb 14, 2017 19:49
by JingoJagget
stu wrote:
JingoJagget wrote:I downloaded the most recent version of this mod, but the armor and player preview ui's don't show up for me. :(

It sounds like use are using creative mode. Either turn off creative or install one of the supported inventory mods, as suggested.

I'm not in creative mode. Are the inventory mods required now? Back in minetest 0.4.13 it worked perfectly without them, but in minetest 0.4.15 it won't show up for some reason. Guess I'll try the inventory mods.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Tue Feb 14, 2017 20:05
by stu
Well it worked last time I tried it but that was a while ago, maybe something has changed in MTG. I will look at it again as soon as I get a chance but in the meantime, using one the inventory mods should fix it.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Wed Feb 15, 2017 08:42
by TenPlus1
Minetest 0.4.15 now uses sfinv for it's inventory and creative menu's which thankfully can be fixed by adding an armor tab into the mix someplace.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Wed Feb 15, 2017 18:55
by stu
TenPlus1 wrote:Minetest 0.4.15 now uses sfinv for it's inventory and creative menu's which thankfully can be fixed by adding an armor tab into the mix someplace.

I just tried it with a recent-ish (~2 weeks old) 0.4.15 build and it's working for me. The formspec style is horribly out-of-date with current MTG but it works...I do, however, plan to add support for sfinv as soon as I get a chance.

@JingoJagget, I can only guess that some other mod you are using is replacing the default player formspec after 3d_armor. If that is the case then you likely will need to use one of the inventory mods.

Update: I have now updated the style of the default armor formspec to be more consistent with MTG.

Image

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Wed Feb 15, 2017 23:16
by JingoJagget
I don't quite like either of the inventory mods, tbh...

Just download sfan5's newest build. Created a world with 3d_armor as the only enabled mod. Still no armor UI. :/

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Wed Feb 15, 2017 23:33
by stu
JingoJagget wrote:I don't quite like either of the inventory mods, tbh...

Just download sfan5's newest build. Created a world with 3d_armor as the only enabled mod. Still no armor UI. :/


There is a new inventory mod you could try smart_inventory
Other than that, sorry, I have no idea what could be wrong there. I do not have access to a windows platform to properly test sfan5's builds.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Thu Feb 16, 2017 00:10
by rubenwardy

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Thu Feb 16, 2017 19:09
by JingoJagget
So let's see if I understand this correctly: having the crafting grid and armor slots on the same inventory screen is no longer possible due to the way minetest works now?? Because that's what I dislike about the other inventory mods, different tabs for everything, and other features I don't use. 3d_armor's UI kept it simple, with the crafting grid and armor slots on the same screen. I'll try to bare with it for now but I hope something can be done about it.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Thu Feb 16, 2017 19:18
by sofar
JingoJagget wrote:So let's see if I understand this correctly: having the crafting grid and armor slots on the same inventory screen is no longer possible due to the way minetest works now?? Because that's what I dislike about the other inventory mods, different tabs for everything, and other features I don't use. 3d_armor's UI kept it simple, with the crafting grid and armor slots on the same screen. I'll try to bare with it for now but I hope something can be done about it.


The issue is that the default crafting page needs to get overwritten. I don't know if rubenwardy can make it so that sfinv can do that.

Perhaps we can make minetest_game check for presence of `an alternative crafting page provider` to solve the issue from that way.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Thu Feb 16, 2017 19:39
by stu
sofar wrote:
JingoJagget wrote:So let's see if I understand this correctly: having the crafting grid and armor slots on the same inventory screen is no longer possible due to the way minetest works now?? Because that's what I dislike about the other inventory mods, different tabs for everything, and other features I don't use. 3d_armor's UI kept it simple, with the crafting grid and armor slots on the same screen. I'll try to bare with it for now but I hope something can be done about it.


The issue is that the default crafting page needs to get overwritten. I don't know if rubenwardy can make it so that sfinv can do that.

Perhaps we can make minetest_game check for presence of `an alternative crafting page provider` to solve the issue from that way.


I still do not understand why this is working for me. Did something change in the last couple of weeks?

@rubenwardy, thanks for that, I will test and merge asap.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Thu Feb 16, 2017 22:17
by JingoJagget
Jeez, there's like a whole investigation team here trying to solve this issue lol.
I definitely don't want anyone having to do extra work because of one person's request. If it can't be done then I'll make my peace with it.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Fri Feb 17, 2017 19:24
by stu
JingoJagget wrote:Jeez, there's like a whole investigation team here trying to solve this issue lol.
I definitely don't want anyone having to do extra work because of one person's request. If it can't be done then I'll make my peace with it.

I would hardy say there was a 'whole investigation team' but you did highlight a potential issue. However, it appears to be possible to override the default crafting page just like any other page, at least it works for me (tm) Nevertheless, armor will have it's own tab when sfinv support is added.

Regarding the current situation, it looks like both armor and sfinv use the same initialization delay so it's probably just pot-luck which formspec you get. So, if you really do want it the old way then you could always remove the sfinv mod ;-) (not tested)

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Fri Feb 17, 2017 19:54
by rubenwardy
sofar wrote:The issue is that the default crafting page needs to get overwritten. I don't know if rubenwardy can make it so that sfinv can do that.


It is possible to override pages, although more than one mod doing this will cause conflicts

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Fri Feb 17, 2017 19:57
by stu
rubenwardy wrote:
sofar wrote:The issue is that the default crafting page needs to get overwritten. I don't know if rubenwardy can make it so that sfinv can do that.


It is possible to override pages, although more than one mod doing this will cause conflicts

Yeah, I agree, if anything the armor tab could include a craft grid, although I was not planning to, maybe that's the answer?

Edit: Actually, no. I would rather add list-rings and display current armor levels like the UI formspec does.

Re: [Modpack] 3D Armor [0.4.7] [minetest-3d_armor]

PostPosted: Thu Mar 02, 2017 11:51
by jakab
i have a problem with this mod. the datas and the armor is on me,so it is working. in the second join, there is no inventory slots where i can put the armor! i tried a fiew thing: inentory plus, mod on/off and stuff like theese. im not lua master so please look around for me :)