Page 2 of 4

PostPosted: Mon Sep 10, 2012 01:45
by Neuromancer
VanessaE wrote:In the 0.0.5...the zip file is named "growing cactus" rather than "growing trees". I guess this wasn't intentional. :-)

Shucks I was really excited to try the new growing trees, so I downloaded it anyway and renamed it to growing trees. Unfortunately it blew up because I think it really is a link to the cactus mod and not the tree mod.

PostPosted: Mon Sep 10, 2012 02:16
by VanessaE
It indeed is the cactus mod, though I found out a little less ... unceremoniously than you did :-)

(I tried to craft two sapling -> one growing tree sapling, which gave no result)

PostPosted: Mon Sep 10, 2012 09:18
by sapier
Sorry I messed up the links, fixed it.

PostPosted: Fri Sep 14, 2012 20:36
by sysedit
The download-service you are using is making me throw up so I have mirrored the newest release.
http://media.w3-net.de/growing_trees-0.0.5.zip

PostPosted: Sat Sep 15, 2012 02:13
by Neuromancer
The growing cactii look beautiful, even while in the process of growing. The growing trees not as much. For example, what I'm seeing is a trunk that grows to about 12 high with a really small clump of leaves at the top. So it looks like a cotton swab. Then after a while small nubs grow out. That might be good for a cactus but not for a tree. I was looking at real trees, and their branches aren't a bunch of horizontal, lshaped and vertical branches. they are more 45% angle and straight up branches, and the branching starts fairly low down like this:

| \ |
\ | |
\ | /
H
H


And also a lot more leaves around all the branches, but not the lower trunk.

PostPosted: Sat Sep 15, 2012 05:04
by sysedit
Neuromancer wrote:The growing cactii look beautiful, even while in the process of growing. The growing trees not as much. For example, what I'm seeing is a trunk that grows to about 12 high with a really small clump of leaves at the top. So it looks like a cotton swab. Then after a while small nubs grow out. That might be good for a cactus but not for a tree. I was looking at real trees, and their branches aren't a bunch of horizontal, lshaped and vertical branches. they are more 45% angle and straight up branches, and the branching starts fairly low down like this:

| \ |
\ | |
\ | /
H
H


And also a lot more leaves around all the branches, but not the lower trunk.

I agree to that. Though my trees are not very big as of now. And I must say I am quite satisfied at what this mod already supplies at this early stage of development.

I have another feature request. Can you instead of crafting the mods saplings with two saplings use the original saplings. It seems to make a lot more sense.

PostPosted: Sat Sep 15, 2012 07:02
by sysedit
Timber mod will not work with growing trees. Since it will only remove "default:jungletree", "default:papyrus", "default:cactus", "default:tree" that are stacked. I am reporting this here because I think there should be a way to not have a world where A lot of trees have a missing trunk below and unreachable wood above and growing_trees does not address this Problem as of yet. Rewriting part of timber is definitive an option. Atm if you just add growing_tree-nodes to timber it will leave you with the trunk missing and the sprout intact. From the code I would say it leaves branches, too. All in all very unsatisfactory atm.

PostPosted: Sat Sep 15, 2012 07:37
by sysedit
Somebody did write code to make timber compatible with growing trees here http://minetest.net/forum/viewtopic.php?id=1590&p=2

PostPosted: Sun Sep 16, 2012 11:31
by sapier
@sysedit @Neuromancer growing trees aren't expected to grow that way I'll have a look whats wrong with it. They should grow branches as soon as thei reach a height of 4.

PostPosted: Sun Sep 16, 2012 19:02
by sapier
@all trees should look much better in growth by this version pleas tell me if they don't

PostPosted: Mon Sep 17, 2012 18:48
by BrandonReese
My trees are growing through a stone structure, is there a fix for that yet? I have one next to a building and the limbs and leaves are replacing some of the stone blocks.

PostPosted: Mon Sep 17, 2012 19:03
by sapier
@BrandonReese I'll have a look at it that shouldn't happen of course

PostPosted: Mon Sep 17, 2012 22:35
by fgr
got crashed while using this mod. some Value where set to NIL, i guess it was the max height .... should be picked up as bug :)

PostPosted: Mon Sep 17, 2012 23:06
by sapier
can you please supply a crash log finding "some values" where nil is a little bit difficult

PostPosted: Mon Sep 17, 2012 23:51
by fgr
Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.
Code: Select all
01:50:02: ERROR[main]: ERROR: An unhandled exception occurred: ServerError: LuaError: error: ...minetest_game/mods/growing_trees/trunk_functions.lua:121: attempt to perform arithmetic on local 'height' (a nil value)
01:50:02: ERROR[main]: stack traceback:

In thread 7fa52956d740:
/build/buildd/minetestc55-0.4.3/src/main.cpp:1741: int main(int, char**): Assertion '0' failed.
Debug stacks:
DEBUG STACK FOR THREAD 7fa52956d740:
#0  int main(int, char**)
(Leftover data: #1  Dedicated server branch)
(Leftover data: #2  virtual void ServerMap::save(ModifiedState))
(Leftover data: #3  virtual void ServerMap::saveBlock(MapBlock*))
(Leftover data: #4  void ItemStack::serialize(std::ostream&) const)
Aborted (core dumped)


Does that helps?

PostPosted: Tue Sep 18, 2012 05:05
by sapier
yes that helps thank you!

PostPosted: Tue Sep 18, 2012 05:35
by sapier
@BrandonReese I've added some additional check please tell me if that doesn't fix your problem.

PostPosted: Tue Sep 18, 2012 16:28
by Spots
hit a bug
12:25:20: VERBOSE[main]: error_message = ServerError: LuaError: error: ....3-win32\bin\..\mods\minetest\growing_trees/abms.lua:209: attempt to compare function with number

PostPosted: Tue Sep 18, 2012 19:53
by sapier
@spots wow you reached maximum tree size ....
replace line 209 by "if math.random() < 0.1 then" I'll release a fixed version soon

PostPosted: Tue Sep 18, 2012 20:05
by Spots
hehehe yea for me breaking stuff lol all i did was cut down the default tress and plant yours all around my home because yours makes things look so much nicer IMO

PostPosted: Tue Sep 18, 2012 20:47
by sapier
Thanks it's always good to hear someone likes your work.

0.0.8 fixes the bug

I hope this was the last one to occurr for some time, I'm getting a little bit ashamed by that simple bugs :)

PostPosted: Tue Sep 18, 2012 21:48
by Spots
no worries man it's all good just keep up the great work

PostPosted: Wed Sep 19, 2012 02:40
by Neuromancer
I'm still getting the really tall trees that have no branches and just a clump of leaves at the top in vesion .8. After a while last time they eventually started growing branches.

PostPosted: Wed Sep 19, 2012 06:02
by sapier
bug was most likely introduced in 0.0.7 ...
abms.lua line 132 replace "local node_at_pos = minetest.env:get_node(pos)"
by "local node_at_pos = minetest.env:get_node(growpos)"

I'll do some more testing this time prior to release of 0.0.9

PostPosted: Wed Sep 19, 2012 07:57
by fgr
Hi, i am looking forward for your next release. I am also a big fan of this brilliant addon it makes the map look really nice !!! :)

PostPosted: Thu Sep 20, 2012 08:39
by fgr
yesterday i reimplemented growing_trees mod. so far i can tell the trees are only growing really high without branches ... this might be a bug?

PostPosted: Thu Sep 20, 2012 17:29
by sapier
Sorry I don't understad what did you do?
I'm a little bit surprised you reimplemented it in only one day :-)

Is 0.0.9 still not growing branches for you?

PostPosted: Thu Sep 20, 2012 19:23
by Spots
i have 0.0.9 installed and having no issues at all the last bug fix is working great

PostPosted: Sun Oct 21, 2012 00:07
by GJH105775
Could you try to use another site such as 2shared that is free to download. It has hit the max downloaders.

PostPosted: Mon Oct 22, 2012 17:02
by Shadowmang
Can you rehost the files? perhaps on ompldr.org or github. because mediafire won't let me access it