[Mod] weather_pack

[Fixerol]

Lua error, possibly related to weather_pack. Was in etherial biome at the time.
http://pastebin.com/raw/9PS5k8Km

BTW, about snow/raining, if I understand it correctly, you can make things much simpler... follow my though:
as in MC make rain and snow event basically the same thing... it is single precipitation event, and type of precipitation depends on what node you are standing, if snow (node or block, or dirt with snow) below your feet - it snows, if you step away from it... it rains.

[Fixerol]

BTW, with rain I get about 18% fps drop :}

[Dopium]

Xeranus's i really enjoy this mod along with sofar's lightening mod however i seem to be getting a bug when lightening strikes. I have reported the bug on sofar's lightening mod however it may have to do with rain. The bug arised after updating to the latest dev build, stable worked fine.

When its raining there is no issues however as soon as lightening strikes it will crash minetest to the desktop. I cannot find any errors in the debug besides this warning.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2016-07-08 12:19:45: WARNING[Server]: Undeclared global variable "dtime" accessed at ...160707\bin\..\games\minetest_2.0\mods\weather\rain\init.lua:143

Not sure if it has anything to do with the way particles behave on the new build.


On a separate matter there is a small bug i noticed for awhile that was the same on stable. After playing for a few hours the set_weather <whatever> command becomes unresponsive, as in it accepts the command but no change in weather conditions. This is no major concern to me as i just exit the world then join again then everythings fine.

[xeranas]

Master was merged into dev branch (general recommendation would be to stick with master branch as dev is more like for experimenting). Warning messages related to dtime should be gone now. Please update lightning mod also since similar issue was fixed. If issue still reproduces after updating both mods then fill bug on weather_pack github and I will take a look.

Second issue is not clear to me, seems that some Lua table data was lost in middle of game. I will check.

[Dopium]

Resolved, thanks for looking into that, dtime warning gone and lightening strikes without crashing.

[BrunoMine]

This mod can be used on a server?

[xeranas]

I'm not sure how minetest works. That server-client architecture quite confusing for me. I guess particle creation should be client responsibility however there are a lot of positions calculations and while they are purely for cosmetic/visual purpose I think they will be done on server side for each player (I do not have control over it or do I?). That being said this mod is not recommended for server.

[ManElevation]

wo this is awesome

[sofar]

Now that the engine has changed, this mod should incorporate several of the following improvements:

- rain particles remove on collision (collision_remove = true) with the gruond
- weather particle spawners can be attached to the player entity now, which should make them far more efficient

FYI particles are "added" by the server, but the server does nothing with them except tell clients. Clients do all the graphical work for particles.

[ErrorNull]

yes, i am greatly anticipating an update to this mod to take advantage of these recent minetest engine improvements!

[xeranas]

Now that the engine has changed, this mod should incorporate several of the following improvements:

- rain particles remove on collision (collision_remove = true) with the gruond
- weather particle spawners can be attached to the player entity now, which should make them far more efficient

Collision check was added some time ago, thought effect is visible for users only 14-dev+ versions.

Simple profiling suggest me that most expensive operation is particle creation by minetest itself, which is unavoidable. For this reason I try to calculate location based on player look dir to "win" few particles. Relative position won't help in this case, build-in particle spawner isn't fit for it either as it uses simple range around logic which does not let verify particle position (e.g. is it in-door).

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.add_particle time: 0.02ms
weather.get_random_pos_by_player_look_dir time: 0.00ms
weather.get_random_pos_by_player_look_dir time: 0.00ms
weather.get_random_pos_by_player_look_dir time: 0.00ms
minetest.add_particle time: 0.02ms
weather.get_random_pos_by_player_look_dir time: 0.00ms
minetest.add_particle time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
minetest.add_particle time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
minetest.add_particle time: 0.02ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.00ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
minetest.add_particle time: 0.04ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.02ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
minetest.add_particle time: 0.04ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
weather.get_random_pos_by_player_look_dir time: 0.01ms
minetest.add_particle time: 0.02ms


[Wuzzy]

It's a good mod which adds nicely to atmosphere. I think I will include it into MineClone 2.

Some comments:

- /help set_weather should say ALL allowed parameters, not just “none”. E.g. “/set_weather none | snow | rain | thunder”
- There's no error message when the user gives no or an invalid parameter to /set_weather.
- The sky is flashing like in a thunder storm even if I just activate the normal rain with /set_weather rain. :-(
- The thunder storm seems to be identical to rain, there only difference is that there are only lightning strikes and additional sounds. I would suggest: More rain drops, louder rain or different rain/storm sound, darker sky.
- It would be great if the weather had some effects, such as snow piling up when it snows or fires being extinguished
- Alternatively, an API function to query the current weather would be extremely useful, so that other mods can add custom events

[Chibi ghost]

I would love this mod but I'm afraid with my already over modded game it would melt my computer

[Wuzzy]

OK, I just figured out the weather_pack already puts out fire when it rains. Good!

But I found something different: skycolor.lua. This appears to be a real API or something. Do you have any explanation on how to use it properly? What is it about with all those layers?

What do I do when I want to change the sky color based on depth (e.g. if the player is at Y<100, the sky turns black regardless of weather)?

[xeranas]

- /help set_weather should say ALL allowed parameters, not just “none”. E.g. “/set_weather none | snow | rain | thunder”
- There's no error message when the user gives no or an invalid parameter to /set_weather.
- The sky is flashing like in a thunder storm even if I just activate the normal rain with /set_weather rain. :-(
- The thunder storm seems to be identical to rain, there only difference is that there are only lightning strikes and additional sounds. I would suggest: More rain drops, louder rain or different rain/storm sound, darker sky.
- It would be great if the weather had some effects, such as snow piling up when it snows or fires being extinguished
- Alternatively, an API function to query the current weather would be extremely useful, so that other mods can add custom events

Thanks, I will review comments. Probably exposing api and letting everyone define weather in more flexible way would solve some issues.

But I found something different: skycolor.lua. This appears to be a real API or something.

Weather mod have embedded skycolor api. Here link to mod post: viewtopic.php?t=15733

Skycolor basically do 2 things:
1) allows register your color layer which is basically color gradient definition in RGB format like: Night Color -> Middle Day -> Night Color (could have more than 3 gradient points).
2) sometimes you do not want to lose previous sky color, that's why here is layers. Active sky is based on last layer. If you done with sky effect just remove_layer(your_layer).