[Mod] Easy crafting table [crafting]

[qwertymine3]

You're right, the grid suggests recipes still. This is what I would do then.

+ Spoiler

That's pretty much the one I just changed from -_- (with the exception that the fields were obnoxiously large in mine).
That said I may change back, as I'm not sure about the usability of the new interface.

I think I'll consider trying to decouple the mod from the UI - so that we could better discuss these UI designs, and to make it possible to embed in a player crafting window.

I'm also thinking of inverting the fields (adding multiple itemlists into the formspec for each visible inventory) to make the fields fill up from the bottom rather than the top - do you think this wouold be a good idea?

[texmex]

I think I'll consider trying to decouple the mod from the UI - so that we could better discuss these UI designs, and to make it possible to embed in a player crafting window.

I'm also thinking of inverting the fields (adding multiple itemlists into the formspec for each visible inventory) to make the fields fill up from the bottom rather than the top - do you think this wouold be a good idea?

Sounds good, both of it!

[IKRadulov]

Hmm this does the same as minecraft xbox / pocket edition crafting ?

[qwertymine3]

Hmm this does the same as minecraft xbox / pocket edition crafting ?

Yes - but the crafting table uses it's own inventory rather than the player inventory.

[texmex]

Thank you for finding that bug - made a simplfication error with one of my bug-fixes previously.
It is now fixed!

Now what happens for me is that the whole client window turns gray and becomes unresponsive instead. macOS, MT 0.4.15.

[azekill_DIABLO]

got away a short time, and now it looks awesome!

[qwertymine3]

Thank you for finding that bug - made a simplfication error with one of my bug-fixes previously.
It is now fixed!

Now what happens for me is that the whole client window turns gray and becomes unresponsive instead. macOS, MT 0.4.15.

Can you please post the contents of your log file when this happens - I will be unable to reproduce otherwise

[texmex]

Sorry, of course. Here you go.

+ Spoiler

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2017-02-17 19:23:58: ERROR[Main]: ServerError: Lua: Runtime error from mod 'crafting' in callback nodemeta_inventory_OnMove(): ...ary/Application Support/minetest/mods/crafting/table.lua:361: bad argument #1 to 'chat_send_all' (string expected, got nil)
2017-02-17 19:23:58: ERROR[Main]: stack traceback:
2017-02-17 19:23:58: ERROR[Main]:    [C]: in function 'chat_send_all'
2017-02-17 19:23:58: ERROR[Main]:    ...ary/Application Support/minetest/mods/crafting/table.lua:361: in function <...ary/Application Support/minetest/mods/crafting/table.lua:350>

[qwertymine3]

Sorry, of course. Here you go.

+ Spoiler

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2017-02-17 19:23:58: ERROR[Main]: ServerError: Lua: Runtime error from mod 'crafting' in callback nodemeta_inventory_OnMove(): ...ary/Application Support/minetest/mods/crafting/table.lua:361: bad argument #1 to 'chat_send_all' (string expected, got nil)
2017-02-17 19:23:58: ERROR[Main]: stack traceback:
2017-02-17 19:23:58: ERROR[Main]:    [C]: in function 'chat_send_all'
2017-02-17 19:23:58: ERROR[Main]:    ...ary/Application Support/minetest/mods/crafting/table.lua:361: in function <...ary/Application Support/minetest/mods/crafting/table.lua:350>

That was just a line for testing and should never have made it into the final commit - it has been removed and the table should work again - thank you for pointing this out.

[texmex]

That was just a line for testing and should never have made it into the final commit - it has been removed and the table should work again - thank you for pointing this out.

Seems to work now, thank you! Can't duplicate nor crash it now. :)

I will try this out on a private server in parallel with the regular crafting system. So instead of the crafting table giving a larger grid like in MC, it gives others powers. Should work okay.

[texmex]

Another idea: How about an option to simply have the mod scanning player inventory directly instead of the player having to place items in the left column? That would essentially be the craftguide with progressive mode but that you may also craft directly in it.

[qwertymine3]

Another idea: How about an option to simply have the mod scanning player inventory directly instead of the player having to place items in the left column? That would essentially be the craftguide with progressive mode but that you may also craft directly in it.

There are a few issues with this idea - the most immediate one being that it would likely introduce a new set of bugs, as both shift clicking items out, and moving items to the crafting inventory both have their own bugs.

There is also issues of practicality:
1. There are 8*4 (32) inventory slots, which would cause a large number of possible crafting combinations - especially for players like me who always have some wood and some stone in their inventory at all times (both very common ingrerdients.

2. It also removes the possibility of using the craftin tables as a persistant workbench to craft a single type of item. I have a work bench with sicks and diamonds for making tools with for example. This also removes any motivation to make more than one other than for convinience.

3. The immediate return o fcrafts into the scanned inventory would cause a large number of updates to the possible outputs - making it quite likely for people to mis-craft items.

4. Some recipes have a 1-1 crafting cost, it would be difficult to allow a player with a full inventory to craft with them and not drop the crafted items.

[texmex]

Thank you for thinking one step ahead there, those are all very valid points!